Display specific, user-friendly error message when upload categories search API call returns an error #6540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5225
What changes did you make and why?
Modified the error handling in
UnsuccessfulResponseInterceptor.interceptso thatMwIOExceptionis raised for non-suppressed errors. The error code and details are parsed into aMwLegacyServiceErrorobject, which is attached toMwIOException.Added a method,
showErrorDialog(String)toUploadCategoriesFragmentandCategoriesContractwhich displays an AlertDialog stating that an error has occurred while loading categories and showing a specific error message.Added handling to
CategoriesPresenterinonAttachViewandonAttachViewWithMediawhich displays an alert with the specific MediaWiki API error when the categories search throwsMwIOException.Tests performed (required)
Tested betaDebug on Medium Phone with API level 35.
Tested prodDebug on Medium Phone with API level 35.
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.