BUG: Fix regression introduced in setRedirectStdInCallbackEnabled

jcfr · jcfr · commit 2401816cc826 · 2025-07-02T16:09:54.000-04:00
This commit fixes a regression introduced in 90220d9 ("[Backport] Replace NULL with nullptr", 2023-01-01)
diff --git a/src/PythonQt.cpp b/src/PythonQt.cpp
@@ -509,11 +509,11 @@ void PythonQt::setRedirectStdInCallbackEnabled(bool enabled)
   sys.setNewRef(PyImport_ImportModule("sys"));
 
   if (enabled) {
-    if( !PyObject_HasAttrString(sys.object(), "pythonqt_stdin") ) {
+    if( PyObject_HasAttrString(sys.object(), "pythonqt_stdin") ) {
       PyObject_SetAttrString(sys.object(), "stdin", PyObject_GetAttrString(sys.object(), "pythonqt_stdin"));
     }
   } else {
-    if( !PyObject_HasAttrString(sys.object(), "pythonqt_original_stdin") ) {
+    if( PyObject_HasAttrString(sys.object(), "pythonqt_original_stdin") ) {
       PyObject_SetAttrString(sys.object(), "stdin", PyObject_GetAttrString(sys.object(), "pythonqt_original_stdin"));
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -509,11 +509,11 @@ void PythonQt::setRedirectStdInCallbackEnabled(bool enabled)`
`509`	`509`	`sys.setNewRef(PyImport_ImportModule("sys"));`
`510`	`510`
`511`	`511`	`if (enabled) {`
`512`		`- if( !PyObject_HasAttrString(sys.object(), "pythonqt_stdin") ) {`
	`512`	`+ if( PyObject_HasAttrString(sys.object(), "pythonqt_stdin") ) {`
`513`	`513`	`PyObject_SetAttrString(sys.object(), "stdin", PyObject_GetAttrString(sys.object(), "pythonqt_stdin"));`
`514`	`514`	`}`
`515`	`515`	`} else {`
`516`		`- if( !PyObject_HasAttrString(sys.object(), "pythonqt_original_stdin") ) {`
	`516`	`+ if( PyObject_HasAttrString(sys.object(), "pythonqt_original_stdin") ) {`
`517`	`517`	`PyObject_SetAttrString(sys.object(), "stdin", PyObject_GetAttrString(sys.object(), "pythonqt_original_stdin"));`
`518`	`518`	`}`
`519`	`519`	`}`