Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ Parameters description:
- `opentelemetry_instrumentors` - a list of extra instrumentors.
- `opentelemetry_exclude_urls` - list of ignored urls.
- `opentelemetry_log_traces` - traces will be logged to stdout.
- `opentelemetry_generate_health_check_spans` - generate spans for health check handlers if `True`

These settings are subsequently passed to [opentelemetry](https://opentelemetry.io/), finalizing your Opentelemetry integration.

Expand Down
7 changes: 6 additions & 1 deletion microbootstrap/instruments/opentelemetry_instrument.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ class OpentelemetryConfig(BaseInstrumentConfig):
],
)
opentelemetry_log_traces: bool = False
opentelemetry_generate_health_check_spans: bool = True


@typing.runtime_checkable
Expand Down Expand Up @@ -169,7 +170,11 @@ def bootstrap(self) -> None:
class OpentelemetryInstrument(BaseOpentelemetryInstrument[OpentelemetryConfig]):
def define_exclude_urls(self) -> list[str]:
exclude_urls = [*self.instrument_config.opentelemetry_exclude_urls]
if self.instrument_config.health_checks_path and self.instrument_config.health_checks_path not in exclude_urls:
if (
not self.instrument_config.opentelemetry_generate_health_check_spans
and self.instrument_config.health_checks_path
and self.instrument_config.health_checks_path not in exclude_urls
):
exclude_urls.append(self.instrument_config.health_checks_path)
return exclude_urls

Expand Down
1 change: 1 addition & 0 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ def minimal_opentelemetry_config() -> OpentelemetryConfig:
opentelemetry_endpoint="/my-engdpoint",
opentelemetry_namespace="namespace",
opentelemetry_container_name="container-name",
opentelemetry_generate_health_check_spans=False,
)


Expand Down