Skip to content

Conversation

@MickLesk
Copy link
Member

✍️ Description

Discontinue support for non-AVX CPUs in Omada installation scripts, exiting with an error if AVX is not detected. Simplify Java installation by using a setup_java function and remove manual Azul Zulu Java installation steps. Update default Omada version from 13 to 12 in scripts and JSON config. Replace manual cleanup steps with cleanup_lxc.

🔗 Related PR / Issue

Link: #9273

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Discontinue support for non-AVX CPUs in Omada installation scripts, exiting with an error if AVX is not detected. Simplify Java installation by using a setup_java function and remove manual Azul Zulu Java installation steps. Update default Omada version from 13 to 12 in scripts and JSON config. Replace manual cleanup steps with cleanup_lxc.
Changed JAVA_VERSION=21 to JAVA_VERSION="21" in omada.sh and omada-install.sh to ensure the variable is treated as a string. This improves consistency and prevents potential issues with variable usage.
@MickLesk MickLesk requested review from a team as code owners November 20, 2025 07:37
@github-actions github-actions bot added json update script A change that updates a script labels Nov 20, 2025
@MickLesk MickLesk added refactor breaking change A change that is not backward compatible labels Nov 20, 2025
Copy link
Member

@tremor021 tremor021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally

@tremor021 tremor021 merged commit 6fc20ae into main Nov 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change A change that is not backward compatible json refactor update script A change that updates a script

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants