Skip to content

Conversation

@kamushadenes
Copy link
Contributor

✍️ Description

For me, it has always been a pain to ensure that a VM or container is only started when another VM or service is up.

Start delays are extremely flaky and inefficient. This script helps solve that.

It's a hookscript that runs on pre-start and waits for all referenced storages to be active. Additionally, it supports tags such as dep_ping_<hostname_or_ip> to wait until a IP is reachable and dep_tcp_<hostname_or_ip>_<port> to wait until a TCP port is open.

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No breaking changes – Existing functionality remains intact.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

🔍 Code & Security Review (X in brackets)

  • Follows Code_Audit.md & CONTRIBUTING.md guidelines
  • Uses correct script structure (AppName.sh, AppName-install.sh, AppName.json)
  • No hardcoded credentials

📋 Additional Information (optional)

@MickLesk
Copy link
Member

Can you clear the PR? 30 Changed files?

@kamushadenes
Copy link
Contributor Author

Oops, I didn’t saw that, I had opened first in the main repo, let me fix this mess.

@kamushadenes kamushadenes force-pushed the feat/dependency-check branch 2 times, most recently from bc8c621 to 3b89a4d Compare August 21, 2025 00:06
@kamushadenes kamushadenes force-pushed the feat/dependency-check branch from 3b89a4d to 3f10206 Compare August 21, 2025 00:07
@kamushadenes
Copy link
Contributor Author

Apologies for the delay, busy week @MickLesk

I think someone had force-pushed to main, that's what caused the issue.

Anyway, it's fixed now.

@MickLesk MickLesk merged commit 2855fee into community-scripts:main Sep 2, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants