Skip to content

Conversation

@salva24
Copy link
Collaborator

@salva24 salva24 commented Sep 16, 2025

No description provided.

salva24 and others added 30 commits August 15, 2025 12:50
…ture paper including forces and diffusion modules
Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com>
Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com>
Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com>
Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com>
Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com>
use *Simulation::GetActive()->GetResourceManager() just once

Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com>
Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com>
Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com>
all fixes into add cart branch
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 85. Check the log or trigger a new build to see more.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@salva24 salva24 marked this pull request as ready for review September 18, 2025 13:07
Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks quite good -- as a next step we will need to figure out how to write tests and benchmarks to make sure the model is stable.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@github-actions
Copy link

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@vgvassilev vgvassilev merged commit 6601f3e into compiler-research:master Sep 18, 2025
3 checks passed
@salva24 salva24 deleted the cart_clean branch September 21, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants