Remove restriction on number of processes for Emscripten static library build on MacOS Github runners #713
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
=======================================
Coverage 79.83% 79.83%
=======================================
Files 9 9
Lines 3963 3963
=======================================
Hits 3164 3164
Misses 799 799 🚀 New features to boost your workflow:
|
mcbarton
force-pushed
the
Increase-number-of-processes-Emscripten-build
branch
2 times, most recently
from
7316569 to
f18dead
Compare
mcbarton
changed the title
mcbarton
force-pushed
the
Increase-number-of-processes-Emscripten-build
branch
from
f279323 to
3db38e6
Compare
…ry build on MacOS Github runners
mcbarton
force-pushed
the
Increase-number-of-processes-Emscripten-build
branch
from
3db38e6 to
199a4e3
Compare
| EMCC_CORES=1 emmake make -j 1 check-cppinterop | ||
| else | ||
| EMCC_CORES=2 emmake make -j 2 check-cppinterop | ||
| emmake make -j ${{ env.ncpus }} check-cppinterop |
There was a problem hiding this comment.
Why are we not doing the same for other OS?
There was a problem hiding this comment.
Because the Linux jobs still crash the ci if you remove the restriction for them. This PR allows us at least remove the restriction on the MacOS jobs while we are able to. Once this is in I plan to open another PR which removes the restriction on the Linux jobs, and I will just keep rebasing that PR every time a new PR goes in until it passes.
There was a problem hiding this comment.
So, is it a problem with emscripten?
There was a problem hiding this comment.
No you can do these build with enough resources (e.g. locally on your laptop which will have more memory). There is no problem with Emscripten. The Github runners are too limited in resources to allow you to do these builds with multiple jobs (at least for now with Linux).
2 participants
Description
Please include a summary of changes, motivation and context for this PR.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist