c_format function looks redundant

[anutosh491]

I don't see a function call to c_format. What is it being used for ? (can it be removed ?)

xeus-cpp/src/xinterpreter.cpp

Lines 342 to 363 in e9df705

	static std::string c_format(const char* format, std::va_list args)
	{
	// Call vsnprintf once to determine the required buffer length. The
	// return value is the number of characters _excluding_ the null byte.
	std::va_list args_bufsz;
	va_copy(args_bufsz, args);
	std::size_t bufsz = vsnprintf(NULL, 0, format, args_bufsz);
	va_end(args_bufsz);
	// Create an empty string of that size.
	std::string s(bufsz, 0);
	// Now format the data into this string and return it.
	std::va_list args_format;
	va_copy(args_format, args);
	// The second parameter is the maximum number of bytes that vsnprintf
	// will write _including_ the terminating null byte.
	vsnprintf(&s[0], s.size() + 1, format, args_format);
	va_end(args_format);
	return s;
	}

[anutosh491]

Check how relevant this issue on xeus-cling (jupyter-xeus/xeus-cling#112) is for xeus-cpp

[anutosh491]

I think we can just get rid of it as we are not injecting any symbols for now. See comment below.

https://github.com/compiler-research/xeus-cpp/pull/46/files#r1535333727

Let's get rid of it.

[vgvassilev]

Yep, go ahead.

[anutosh491]

Raised a PR for the same.