Skip to content

Conversation

@thekaveman
Copy link
Member

@thekaveman thekaveman commented Sep 29, 2023

Closes #93

What this PR does

Introduces a devcontainer setup, to make it easier to build and run this site locally. Devcontainer installs dependencies as root, but switches to a non-root user compiler

❗❗ Reorganizes the site content (e.g. HTML, CSS, images) into the src/ directory to keep things together and follow our normal pattern in other sites.

Added this repo as a Netlify site so we get free PR / branch previews. Will turn off GitHub pages once this PR is merged, and migrate DNS to the Netlify site #112

Testing this PR

  1. Checkout the branch
  2. Open in VS Code
  3. Rebuild and Reopen in devcontainer
  4. Run the build task > Tasks: Run Build Task or Ctrl/Cmd + Shift + B
  5. Confirm the site builds and you can open it at http://localhost:PORT (4000 by default but assigned by Docker)
  6. Confirm no visual or content regressions

See also

compilerla/compiler.la#123

@thekaveman thekaveman closed this Sep 29, 2023
@thekaveman thekaveman deleted the chore/devcontainer branch September 29, 2023 20:03
@thekaveman thekaveman restored the chore/devcontainer branch September 29, 2023 20:04
@thekaveman thekaveman reopened this Sep 29, 2023
@netlify
Copy link

netlify bot commented Sep 29, 2023

Deploy Preview for data-donuts ready!

Name Link
🔨 Latest commit 305b40f
🔍 Latest deploy log https://app.netlify.com/sites/data-donuts/deploys/66e7b93d1598ae0008a46936
😎 Deploy Preview https://deploy-preview-111--data-donuts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thekaveman thekaveman marked this pull request as draft October 31, 2023 18:26
@thekaveman
Copy link
Member Author

Moving back to draft until we start back up on this website in earnest.

@machikoyasuda machikoyasuda removed their request for review August 8, 2024 23:38
@thekaveman thekaveman removed the request for review from angela-tran September 16, 2024 04:41
@thekaveman thekaveman marked this pull request as ready for review September 16, 2024 04:57
@thekaveman thekaveman merged commit 4f42225 into main Sep 16, 2024
@thekaveman thekaveman deleted the chore/devcontainer branch September 16, 2024 04:57
@machikoyasuda
Copy link
Member

Compiler is now on devcontainers for all of our major sites! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure for local development

3 participants