Skip to content

Conversation

@George-Miao
Copy link
Member

@George-Miao George-Miao commented Sep 10, 2025

Closes #474

Some explanation in Chinese: https://t.me/compio_rs/26252. @kanarus could you please test with this branck again?

@George-Miao George-Miao self-assigned this Sep 10, 2025
@George-Miao George-Miao added the bug Something isn't working label Sep 10, 2025
@kanarus
Copy link

kanarus commented Sep 10, 2025

@George-Miao It seems correctly working!

https://github.com/kanarus/test-compio-timeout/tree/fix/timeout-error

cargo run --features compio
   Compiling compio-buf v0.7.0 (https://github.com/George-Miao/compio?branch=fix%2Ftimeout-error#2cd512b4)
   Compiling compio-driver v0.9.0 (https://github.com/George-Miao/compio?branch=fix%2Ftimeout-error#2cd512b4)
   Compiling compio-fs v0.9.0 (https://github.com/George-Miao/compio?branch=fix%2Ftimeout-error#2cd512b4)
   Compiling compio-log v0.1.0 (https://github.com/George-Miao/compio?branch=fix%2Ftimeout-error#2cd512b4)
   Compiling compio-io v0.8.0 (https://github.com/George-Miao/compio?branch=fix%2Ftimeout-error#2cd512b4)
   Compiling compio-runtime v0.9.0 (https://github.com/George-Miao/compio?branch=fix%2Ftimeout-error#2cd512b4)
   Compiling compio-net v0.9.0 (https://github.com/George-Miao/compio?branch=fix%2Ftimeout-error#2cd512b4)
   Compiling compio v0.16.0 (https://github.com/George-Miao/compio?branch=fix%2Ftimeout-error#2cd512b4)
   Compiling test-compio-timeout v0.1.0 (/home/kanarus/projects/kanarus/test-compio-timeout)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.43s
     Running `target/debug/test-compio-timeout`
None, None
None, None
None, None
None, None
None, None
None, None
None, None
None, None
None, None
None, None

@George-Miao
Copy link
Member Author

We are still debating on whether this quick dirty fix is sufficient (it's an O(n) situation everytime a timer gets dropped so not really optimal).

@George-Miao George-Miao changed the title fix: timer waking up canceled tasks refactor: timer Sep 10, 2025
@George-Miao George-Miao added package: runtime Related to compio-runtime refactor Refactoring existing code labels Sep 10, 2025
@George-Miao
Copy link
Member Author

We're refactoring the whole timer now, after some discussion

Copy link
Member

@Berrysoft Berrysoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft Berrysoft merged commit 4ef5a19 into compio-rs:master Sep 10, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working package: runtime Related to compio-runtime refactor Refactoring existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

timeout doesn't work as expected

3 participants