fix(runtime): use Weak to break reference cycle
#490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berrysoft
approved these changes
Oct 19, 2025
Member
|
Thanks anyways. I have considered weak refs, but didn't use it because of performance considerations. Now it seems necessary so... |
Berrysoft
reviewed
Oct 27, 2025
| } | ||
| } | ||
|
|
||
| impl Drop for Runtime { |
Member
There was a problem hiding this comment.
Oh, no. This change may make the runtime panic on drop. The runnables should be dropped in self.enter, or they cannot find the right runtime to cancel the time futures.
Contributor
Author
There was a problem hiding this comment.
Also, I recently discovered that if a Waker is dropped in another thread and the Weak upgrade fails inside schedule, the Runnable end up being dropped in that other thread. I’m currently looking into how async-executor implements this.
Member
There was a problem hiding this comment.
We might want to forget the runnable in that case...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #489