feat: adjust features #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the TLS and WebSocket feature flags in the main compio crate to provide more granular control over optional dependencies. The changes decouple feature dependencies to allow users to enable rustls or native-tls without automatically enabling the base tls feature, and similarly separates WebSocket connectivity features from the base ws feature.
Key changes:
- Decouples
native-tlsandrustlsfeatures from the basetlsfeature using optional dependency syntax (compio-tls?/) - Separates
ws-connectfeature from the basewsfeature, removing the implicitconnectdependency - Adds
tlsfeature to theallfeature bundle and renamesws-rustlstows-connect
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
George-Miao
approved these changes
Nov 11, 2025
Member
George-Miao
left a comment
George-Miao
left a comment
There was a problem hiding this comment.
I think this is a breaking change, though not sure. LGTM.
Member
Author
|
Let's postpone this PR then. |
Berrysoft
force-pushed
the
refactor/features
branch
from
66c9c44 to
ea75c49
Compare
Berrysoft
added a commit
to Berrysoft/compio
that referenced
this pull request
Nov 16, 2025
This reverts commit 70ceb41.
Berrysoft
added a commit
that referenced
this pull request
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not that sure if it should be considered as a breaking change.