Skip to content

Conversation

@George-Miao
Copy link
Member

@George-Miao George-Miao commented Nov 19, 2025

No description provided.

@George-Miao George-Miao requested review from Berrysoft and Copilot and removed request for Berrysoft November 19, 2025 04:40
Copilot finished reviewing on behalf of George-Miao November 19, 2025 04:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a unified Config struct for compio-ws that consolidates WebSocket configuration, buffer sizing, and Nagle's algorithm settings. The changes aim to provide a more flexible and ergonomic API through the builder pattern and trait implementations.

  • Introduces a new Config struct with builder methods to replace disparate parameters
  • Updates all _with_config functions to accept impl Into<Config> for ergonomic usage
  • Standardizes unit notation from "KB" to "KiB" across documentation

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
compio-ws/src/lib.rs Adds Config struct with builder pattern and trait implementations; updates function signatures to use Config; makes client_async_with_config private
compio-ws/src/tls.rs Updates imports and function signatures to use new Config type; extracts Nagle setting from config
compio-io/src/write/buf.rs Corrects documentation from "KB" to "KiB"
compio-io/src/util/mod.rs Corrects documentation from "KB" to "KiB"
compio-io/src/read/buf.rs Corrects documentation from "KB" to "KiB"
compio-io/src/compat/sync_stream.rs Corrects documentation from "KB"/"MB" to "KiB"/"MiB"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

George-Miao and others added 2 commits November 18, 2025 23:44
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@George-Miao George-Miao added this to the v0.17 milestone Nov 19, 2025
@George-Miao George-Miao self-assigned this Nov 19, 2025
@George-Miao George-Miao added package: tls Related to compio-tls package: ws Related to compio-ws enhancement New feature or request labels Nov 19, 2025
Copy link
Member

@Berrysoft Berrysoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@George-Miao George-Miao merged commit 3a8faca into compio-rs:master Nov 19, 2025
50 checks passed
@George-Miao George-Miao deleted the feat/ws-config branch November 19, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request package: tls Related to compio-tls package: ws Related to compio-ws

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants