succeed qModuleInfo when ELF file has no build ID
#165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The ds2 implementation for handling the
qModuleInfopacket fails when it is unable to retrieve an ELF build ID from the module. This failure causeslldbto stop fetching info for subsequent modules. This PR addresses the issue by makingqModuleInfosucceed in this case and excluding theuuidfield from the response.Validation
GitHub build & test
Locally verified debugging a Swift test that imports modules w/out build IDs. Images for all modules with build IDs load and symbols resolve correctly.