Add _Pointer protocol with init?(bitPattern:)
#35
Conversation
Sources/Core/Pointer.swift
Outdated
|
|
||
| @_transparent | ||
| init?(bitPattern: Int) { | ||
| guard bitPattern != 0 else { return nil } |
There was a problem hiding this comment.
Any reason to prefer guard here rather than if bitPattern == 0 { return nil }
Sources/Core/Pointer.swift
Outdated
|
|
||
| public extension _Pointer { | ||
| @_transparent | ||
| init(_ from: OpaquePointer) { |
There was a problem hiding this comment.
I think being more explicit and marking the methods as public is better than just marking the extension as public
There was a problem hiding this comment.
I hope a lot of these changes can be applied by formatters and linters. Do you have any preference for specific once? I use SwiftLint and SwiftFormat locally, would it make sense to create a separate PR with configurations for those?
There was a problem hiding this comment.
I would say that swift-format would be better than SwiftLint, but I don't think that swift-format really can format the code in the style that I would prefer. If you want to add a configuration for swift-format in a separate PR, I am okay with that.
2 participants
This initializer is needed to fully implement
StaticString.Depends on #34.