Skip to content

Conversation

@balazsmatepetro
Copy link
Contributor

@balazsmatepetro balazsmatepetro commented May 14, 2020

Make it possible to use complex selectors like :active:not([aria-disabled="true"]) by generating random class name

@changeset-bot
Copy link

changeset-bot bot commented May 14, 2020

🦋 Changeset is good to go

Latest commit: 23cdfd5

We got this.

This PR includes changesets to release 1 package
Name Type
@component-driven/with-selector Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@okonet
Copy link
Member

okonet commented May 14, 2020

@balazsmatepetro thanks for contributing! Could you please describe your changes in the issue so I can better understand the context. Also, the changeset is missing and should be added to this PR in order for it to be released.

@balazsmatepetro balazsmatepetro requested a review from okonet May 14, 2020 14:09
@okonet okonet changed the title fix: Generate random class name to make possible use complex selectors fix: Make possible to use with complex selectors May 15, 2020
@okonet okonet changed the title fix: Make possible to use with complex selectors feat: Make possible to use with complex selectors May 15, 2020
@okonet okonet merged commit 58f8ad4 into component-driven:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants