Add focusable parameter to Flyout and defaults to true
#123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Popup behavior. Introduced a `focusable` parameter to the `Flyout`, `MenuFlyout`, and related components to control whether the flyout is focusable. This allows interaction with areas outside the flyout when set to `false`. Updated default focus behavior across components for consistency. Adjusted `FluentDialog` and `Dropdown` to align with the new focusable defaults.
Sanlorng
reviewed
Jun 14, 2025
| positionProvider: FlyoutPositionProvider = rememberFlyoutPositionProvider(), | ||
| onKeyEvent: ((keyEvent: KeyEvent) -> Boolean)? = null, | ||
| onPreviewKeyEvent: ((keyEvent: KeyEvent) -> Boolean)? = null, | ||
| focusable: Boolean = true, |
Collaborator
There was a problem hiding this comment.
Suggested change
| focusable: Boolean = true, | |
| focusable: Boolean = onKeyEvent != null || onPreviewKeyEvent != null, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
focusableparameter in PopupProperties controls certain interaction behaviors, particularly for components like Dialog, Flyout, and Dropdown. Previously, setting it tofalseallowed users to click the DropdownButton multiple times, which causes animation problems.However, some components do require this behavior. For example, a
MenuBarneeds to be able to display a new menu immediately when the user hovers over another menu button.So, I exposed this parameter, allows components to choose the expected behavior.
Meanwhile, adjusted the
focusablesetting for Dialog specifically, as Dialog components also need to handle keyboard interactions from users.