Skip to content

Optimize OtherComponent and ProgressIndicator #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 30, 2025
Merged

Optimize OtherComponent and ProgressIndicator #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb245a3
example: Optimize OtherComponent performance
Ryan1202 May 29, 2025
be15d38
library: Optimize ProgressIndicator Components
Ryan1202 May 30, 2025
b5dd896
Merge remote-tracking branch 'origin/main'
Ryan1202 May 30, 2025
50c5924
Merge remote-tracking branch 'origin/main'
Ryan1202 May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions example/src/commonMain/kotlin/MainPage.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,13 @@ import androidx.compose.runtime.remember
import androidx.compose.runtime.setValue
import androidx.compose.ui.Modifier
import androidx.compose.ui.input.nestedscroll.nestedScroll
import androidx.compose.ui.platform.LocalFocusManager
import androidx.compose.ui.text.TextStyle
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp
import component.OtherComponent
import component.TextComponent
import component.otherComponent
import top.yukonga.miuix.kmp.basic.BasicComponent
import top.yukonga.miuix.kmp.basic.InputField
import top.yukonga.miuix.kmp.basic.ScrollBehavior
Expand Down Expand Up @@ -97,11 +98,11 @@ fun MainPage(
superSwitchAnimState
)
}
val otherComponent = @Composable { OtherComponent(padding) }

BoxWithConstraints(
modifier = Modifier.fillMaxSize()
) {
val focusManager = LocalFocusManager.current
if (maxWidth < 840.dp) {
LazyColumn(
modifier = Modifier
Expand Down Expand Up @@ -166,8 +167,8 @@ fun MainPage(
if (!expanded) {
item {
textComponent()
otherComponent()
}
otherComponent(focusManager, padding)
}
}
} else {
Expand Down Expand Up @@ -232,8 +233,8 @@ fun MainPage(
}
}
if (!expanded) {
otherComponent(focusManager, padding)
item {
otherComponent()
Spacer(modifier = Modifier.height(6.dp))
}
}
Expand Down
Loading