do not ignore WithDotEnv errors #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahedouch
force-pushed
the
update-compose-env-var
branch
from
e87db33 to
eacbd54
Compare
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
fahedouch
force-pushed
the
update-compose-env-var
branch
from
eacbd54 to
f4fa942
Compare
Collaborator
|
Sounds good, but code need to distriguish use of the default env file ( |
Contributor
Author
|
@ndeloof indeed the error is triggered only when |
ndeloof
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Applying some docker-compose behavior to the Compose cli :
When an invalid file path is being passed as --env-file argument, Compose should returns an error (https://docs.docker.com/compose/environment-variables/#using-the---env-file--option)
When a directory is being passed as -f argument Compose should returns an error
Signed-off-by: fahed dorgaa fahed.dorgaa@gmail.com