Remove only full line comments to avoid variable interpolation on this ones #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumpl
approved these changes
Aug 19, 2021
Collaborator
|
LGTM but then we need another way to remove comments :'( |
Collaborator
|
I guess unmarshall+marshall way to drop comments also caused docker-archive/compose-cli#2036 |
Collaborator
|
I suggest |
Signed-off-by: Ulysses Souza <ulyssessouza@gmail.com>
ulyssessouza
force-pushed
the
remove-pre-parsing
branch
from
b49c280 to
354db4d
Compare
ndeloof
approved these changes
Aug 24, 2021
ulyssessouza
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is due to the Marshal and Unmarshal methods
also remove double quotes from strings.
This breaks empty strings turning it into
nilvalues.PTAL @lorenrh
Signed-off-by: Ulysses Souza ulyssessouza@gmail.com