run interpolation on parsed yaml tree #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
changed the title
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
interpolate_yaml_nodes
branch
from
5fdd29e to
ba39ede
Compare
ndeloof
added a commit
to ndeloof/compose-cli
that referenced
this pull request
Aug 30, 2021
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically reverts #142
run interpolation on parsed YAML tree, not ray file, as this triggered too much issues/regressions
We will haved to take check all the non-string compose attributes are well declared for type casting under
interpolateTypeCastMappingPoC: docker-archive/compose-cli#2048