transformSize accept UnitBytes created by interpolation #183
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat007
reviewed
Sep 14, 2021
Contributor
mat007
left a comment
mat007
left a comment
There was a problem hiding this comment.
Should we add a default: and return an error to avoid possible panics in the future?
loader/loader.go
Outdated
Comment on lines
1008
to
1009
| case int64: | ||
| return value, nil | ||
| case types.UnitBytes: | ||
| return value, nil |
Contributor
There was a problem hiding this comment.
nit: It think this may work
Suggested change
| case int64: | |
| return value, nil | |
| case types.UnitBytes: | |
| return value, nil | |
| case int64, types.UnitBytes: | |
| return value, nil |
?
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Collaborator
Author
|
That's indeed weird this TransformerFunc uses |
2 tasks
|
There might still be a problem @ndeloof, see docker/compose#8613 (comment). Might be a regression ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interpolation produces the expected
UnitBytestype for shm_size and comparable fieldsthis PR updates
transformSizeso it is a no-op when type is already correctclose docker/compose#8613