Skip to content

caller might not need a compose.yaml file until calling NewProjectOptions #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2021
Merged

caller might not need a compose.yaml file until calling NewProjectOptions #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions cli/options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import (
"regexp"
"strings"

"github.com/compose-spec/compose-go/errdefs"
"github.com/compose-spec/compose-go/loader"
"github.com/compose-spec/compose-go/types"
"github.com/compose-spec/godotenv"
Expand Down Expand Up @@ -131,7 +130,8 @@ func WithDefaultConfigPath(o *ProjectOptions) error {
}
parent := filepath.Dir(pwd)
if parent == pwd {
return errors.Wrap(errdefs.ErrNotFound, "can't find a suitable configuration file in this directory or any parent")
// no config file found, but that's not a blocker if caller only needs project name
return nil
}
pwd = parent
}
Expand Down Expand Up @@ -364,7 +364,6 @@ func getConfigPathsFromOptions(options *ProjectOptions) ([]string, error) {
if len(options.ConfigPaths) != 0 {
return absolutePaths(options.ConfigPaths)
}

return nil, errors.New("no configuration file provided")
}

Expand Down