Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logic branching for conda_43/conda_44/conda_45/conda_46/conda_47 #4677

Merged
merged 9 commits into from
Dec 22, 2022
Merged

Remove logic branching for conda_43/conda_44/conda_45/conda_46/conda_47 #4677

merged 9 commits into from
Dec 22, 2022

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Dec 16, 2022 •
edited
Loading

Description

Since conda-build's minimum compatible conda is 4.13 we can remove all older conda logic.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard self-assigned this Dec 16, 2022
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Dec 16, 2022
@kenodegard kenodegard added source::anaconda created by members of Anaconda, Inc. in-progress issue is actively being worked on labels Dec 16, 2022
sven6002
sven6002 reviewed Dec 16, 2022
View reviewed changes
Copy link
Contributor

@sven6002 sven6002 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you comment on the epic as well that these pieces are removed

#4590

sven6002
sven6002 previously approved these changes Dec 16, 2022
View reviewed changes
@kenodegard kenodegard mentioned this pull request Dec 16, 2022
Closed
46 tasks
beeankha
beeankha previously approved these changes Dec 16, 2022
View reviewed changes
mbargull
mbargull requested changes Dec 16, 2022
View reviewed changes
conda_build/render.py Outdated Show resolved Hide resolved
conda_build/utils.py Show resolved Hide resolved
tests/test_api_build.py Show resolved Hide resolved
@kenodegard kenodegard dismissed stale reviews from beeankha and sven6002 via 458f8d4 December 16, 2022 21:50
beeankha
beeankha approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@beeankha beeankha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @kenodegard !

mbargull
mbargull approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@mbargull mbargull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ongoing housekeeping effort!
clean all the things!

@kenodegard kenodegard merged commit db9a728 into conda:main Dec 22, 2022
@kenodegard kenodegard deleted the deprecate-conda_NN branch December 22, 2022 17:29
@kenodegard kenodegard mentioned this pull request Dec 22, 2022
Closed
@kenodegard kenodegard mentioned this pull request Jan 6, 2023
Closed
@github-actions github-actions bot added the locked [bot] locked due to inactivity label Dec 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@beeankha beeankha beeankha approved these changes

@mbargull mbargull mbargull approved these changes

@travishathaway travishathaway travishathaway approved these changes

@sven6002 sven6002 sven6002 left review comments

Assignees

@kenodegard kenodegard

Labels
cla-signed [bot] added once the contributor has signed the CLA in-progress issue is actively being worked on locked [bot] locked due to inactivity source::anaconda created by members of Anaconda, Inc.
Projects
🧭 Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kenodegard @travishathaway @mbargull @beeankha @sven6002 @conda-bot