Skip to content

Conversation

@DmitryBorisov-sm
Copy link
Contributor

@DmitryBorisov-sm DmitryBorisov-sm commented Oct 16, 2025

Please note: everything in the open-api folder is autogenerated by openapi-ts and could be ignored

@DmitryBorisov-sm DmitryBorisov-sm marked this pull request as ready for review October 20, 2025 17:28
@DmitryBorisov-sm DmitryBorisov-sm merged commit d15580a into main Oct 23, 2025
17 of 20 checks passed
@mrlubos
Copy link

mrlubos commented Oct 23, 2025

@DmitryBorisov-sm let me know if you have any feedback on Hey API! Maybe @EugeneKisel-sm would be interested in using it for the Python SDK in the future? 🤞

@DmitryBorisov-sm
Copy link
Contributor Author

@DmitryBorisov-sm let me know if you have any feedback on Hey API! Maybe @EugeneKisel-sm would be interested in using it for the Python SDK in the future? 🤞

Hi @mrlubos !
Overall, the library impressed me compared to the previous one, thanks to its flexibility and extensibility, so I’ve already recommended it to the team.

Here’s a brief summary of the difficulties I encountered:

  1. throwOnError needs to be explicitly specified for each individual generated method call so that TypeScript understands the method won’t return undefined if an error occurs. I’d prefer similar behavior when creating a client with throwOnError set globally.
  2. I ran into problems with type "object" properties that lacked additionalProperties - these weren’t generated. Similarly, fields containing objects nested within additionalProperties weren’t generated either, although string fields worked fine. These issues weren’t present in version 81 but started appearing in version 82. I wasn’t able to create a minimal reproduction case, but that’s how it behaves with our specification - which is quite large.

@mrlubos
Copy link

mrlubos commented Oct 24, 2025

Happy to discuss these further, are you on Slack? I joined it but couldn't find you by name.

  1. I thought you could set throwOnError on the client plugin to achieve this. Did that not work?

  2. If you can share a test case I'll look into it. Feel free to open an issue or message me on your Slack/Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants