Skip to content

Conversation

@IgorChvyrov-sm
Copy link
Contributor

@IgorChvyrov-sm IgorChvyrov-sm commented Sep 10, 2025

Changes:

Updated sync API client to enable proxy configuration
Updated config to make it possible to set proxy via env vars
Added proxy section to README.md
Added examples with proxy configuration

@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 73.07692% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/conductor/client/adapters/rest_adapter.py 62.50% 9 Missing ⚠️
...ctor/asyncio_client/configuration/configuration.py 42.85% 4 Missing ⚠️
...rc/conductor/client/configuration/configuration.py 95.23% 1 Missing ⚠️
Files with missing lines Coverage Δ
...rc/conductor/client/configuration/configuration.py 90.65% <95.23%> (+0.43%) ⬆️
...ctor/asyncio_client/configuration/configuration.py 97.67% <42.85%> (-2.33%) ⬇️
src/conductor/client/adapters/rest_adapter.py 92.96% <62.50%> (-7.04%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IgorChvyrov-sm IgorChvyrov-sm marked this pull request as ready for review September 16, 2025 14:06
Base automatically changed from feature_enable_http2 to refactoring_improve_sdk_logging September 17, 2025 08:53
Base automatically changed from refactoring_improve_sdk_logging to refactoring_separate_generated_code September 17, 2025 08:54
@IgorChvyrov-sm IgorChvyrov-sm changed the base branch from refactoring_separate_generated_code to main October 3, 2025 11:08
Copy link

@nthmost-orkes nthmost-orkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great except for one little thing -- CONDUCTOR_PROXY_HEADERS has several tests around it while CONDUCTOR_PROXY has zero (apparently?).

We should have at least one test around this variable to protect it, i.e. make it more obvious when we might be about to do a release that changes something about how the SDK is operated.

@IgorChvyrov-sm
Copy link
Contributor Author

This looks great except for one little thing -- CONDUCTOR_PROXY_HEADERS has several tests around it while CONDUCTOR_PROXY has zero (apparently?).

We should have at least one test around this variable to protect it, i.e. make it more obvious when we might be about to do a release that changes something about how the SDK is operated.

Sure, just missed that. Thanks for notice -- done

Copy link

@nthmost-orkes nthmost-orkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for the updates!

@IgorChvyrov-sm IgorChvyrov-sm merged commit 786f796 into main Oct 8, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants