-
Notifications
You must be signed in to change notification settings - Fork 37
Add ability to configure proxy #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s and moved shared enums
This reverts commit cb9fc88.
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
nthmost-orkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great except for one little thing -- CONDUCTOR_PROXY_HEADERS has several tests around it while CONDUCTOR_PROXY has zero (apparently?).
We should have at least one test around this variable to protect it, i.e. make it more obvious when we might be about to do a release that changes something about how the SDK is operated.
Sure, just missed that. Thanks for notice -- done |
nthmost-orkes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you for the updates!
Changes:
Updated sync API client to enable proxy configuration
Updated config to make it possible to set proxy via env vars
Added proxy section to README.md
Added examples with proxy configuration