Skip to content

Conversation

jreidinger
Copy link
Contributor

@jreidinger jreidinger commented Jul 18, 2019

SLE12 SP5 gets new cfa because of set of bug fixes including L3 fixes. This cause grub2_cfa failing there as can be seen at https://build.suse.de/package/view_file/home:repo-checker/reports/SUSE:SLE-12-SP5:GA:Staging:A

Backport aim to be minimal, so no rubocop changes done.

@coveralls
Copy link

coveralls commented Jul 18, 2019

Coverage Status

Coverage remained the same at 98.214% when pulling 31ca25b on Backport_cfa1 into cb57a5b on SLE-12-SP5.

@mvidner
Copy link
Contributor

mvidner commented Jul 18, 2019

OK. Now this repo will have a SLE-12-SP5 branch but https://github.com/config-files-api/config_files_api will not, until we need to diverge that repo, right?

"fix testsuite" 0ca07bc is missing a trailing quote so it broke it in another way.

@jreidinger
Copy link
Contributor Author

@mvidner yes, for cfa and its plugin plan is to not diverge as much as possible for easier maintenance. But in this case it will need backporting another feature to yast2-bootloader due to terminal API changes, so I backport it here.

@jreidinger jreidinger merged commit 5a2c2f0 into SLE-12-SP5 Jul 18, 2019
@jreidinger jreidinger deleted the Backport_cfa1 branch July 18, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants