Configurable batch size #389
Draft
+201
−123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airlock-confluentinc
bot
force-pushed
the
dev_fix_configurable_batch_size
branch
from
e881b8f to
6900c8c
Compare
emasab
changed the base branch from
master
to
dev_performance_test_improvements
airlock-confluentinc
bot
force-pushed
the
dev_performance_test_improvements
branch
from
9e73424 to
ed0fb03
Compare
emasab
changed the base branch from
dev_performance_test_improvements
to
master
emasab
changed the base branch from
master
to
dev_performance_test_improvements
airlock-confluentinc
bot
force-pushed
the
dev_fix_configurable_batch_size
branch
from
6900c8c to
9b3c43a
Compare
airlock-confluentinc
bot
force-pushed
the
dev_performance_test_improvements
branch
2 times, most recently
from
15928f1 to
4209743
Compare
airlock-confluentinc
bot
force-pushed
the
dev_fix_configurable_batch_size
branch
from
9b3c43a to
25ec968
Compare
airlock-confluentinc
bot
force-pushed
the
dev_performance_test_improvements
branch
from
4209743 to
9f4461f
Compare
airlock-confluentinc
bot
force-pushed
the
dev_fix_configurable_batch_size
branch
from
25ec968 to
7d20ea4
Compare
airlock-confluentinc
bot
force-pushed
the
dev_fix_configurable_batch_size
branch
from
7d20ea4 to
e8bd34f
Compare
airlock-confluentinc
bot
force-pushed
the
dev_fix_configurable_batch_size
branch
from
8bb5221 to
4ad7f02
Compare
rebalances in case of long processing time
airlock-confluentinc
bot
force-pushed
the
dev_fix_configurable_batch_size
branch
3 times, most recently
from
f776f0c to
0a91e33
Compare
airlock-confluentinc
bot
force-pushed
the
dev_fix_configurable_batch_size
branch
from
0a91e33 to
e62aee1
Compare
airlock-confluentinc
bot
force-pushed
the
dev_fix_configurable_batch_size
branch
from
92368f1 to
cfa7321
Compare
airlock-confluentinc
bot
force-pushed
the
dev_fix_configurable_batch_size
branch
from
94e66ba to
4f22357
Compare
This comment has been minimized.
This comment has been minimized.
Analysis Details11 Issues
Coverage and Duplications
Project ID: confluent-kafka-javascript |
milindl
reviewed
Oct 21, 2025
| @@ -1,3 +1,12 @@ | |||
| # confluent-kafka-javascript 1.6.1 | |||
|
|
|||
| v1.6.1 is a maintenance release. It is supported for all usage. | |||
Comment on lines
+306
to
+308
| - An API compatible version of `eachBatch` is available, maximum batch size | ||
| can be configured through the `js.consumer.max.batch.size` configuration property | ||
| and defaults to 32. |
There was a problem hiding this comment.
Suggested change
| - An API compatible version of `eachBatch` is available, maximum batch size | |
| can be configured through the `js.consumer.max.batch.size` configuration property | |
| and defaults to 32. | |
| - An API compatible version of `eachBatch` is available, maximum batch size | |
| can be configured through the `js.consumer.max.batch.size` configuration property | |
| and defaults to 32. It is not dependent on the size of the batches present on the broker, as the batches are constructed client-side. |
There was a problem hiding this comment.
Also, I think we should add that while we start attempting to fill batches with js.consumer.max.batch.size, it may be scaled down based on the actual messages received.
| this.#cacheExpirationTimeoutMs = this.#maxPollIntervalMs; | ||
| rdKafkaConfig['max.poll.interval.ms'] = this.#maxPollIntervalMs * 2; | ||
|
|
||
| if (rdKafkaConfig['js.consumer.max.batch.size'] !== undefined) { |
There was a problem hiding this comment.
Suggested change
| if (rdKafkaConfig['js.consumer.max.batch.size'] !== undefined) { | |
| if (Object.hasOwn(rdKafkaConfig, 'js.consumer.max.batch.size')) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #286.
batch size is now configurable through the 'js.max.batch.size` property (-1 for unlimited batch size). Even when unlimited batch sizes are actually limited by librdkafka consumer buffer.
Checklist
Test & Review
automatic tests and running the performance example