Skip to content

Conversation

@davetroiano
Copy link
Contributor

@davetroiano davetroiano commented Aug 4, 2022

Updates the anomaly detection tutorial so that the automated ksq-test-runner test uses hard-coded values, while the records in markup have dynamic recent (within the past seven days) timestamps so that the tutorial feels fresher and so that the non-ksql-test-runner part of build automation isn't subject to race condition (old records getting deleted).

@davetroiano davetroiano requested review from a team and colinhicks as code owners August 4, 2022 13:44
@davetroiano davetroiano force-pushed the anomaly-detection-dynamic-timestamps branch from ef4c494 to e90ad49 Compare October 20, 2022 17:52
@davetroiano davetroiano changed the title [DO NOT MERGE] update anomaly detection tutorial to use timestamps based on run time update anomaly detection tutorial to use timestamps based on run time Oct 20, 2022
@davetroiano
Copy link
Contributor Author

push pipeline tests pass

Copy link
Contributor

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


ksqldb-cli:
image: confluentinc/ksqldb-cli:0.13.0
image: confluentinc/ksqldb-cli:0.24.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on both of these

@davetroiano davetroiano merged commit 78ee521 into master Oct 21, 2022
@davetroiano davetroiano deleted the anomaly-detection-dynamic-timestamps branch October 21, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants