- 
                Notifications
    
You must be signed in to change notification settings  - Fork 94
 
GH #562: Remove config dependency on ZooKeeper (not ZooKeeper the service) #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           💯 for removing zookeeper config in SR!  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅 @awalther28 great improvement across the board. Left 2 comments: one missed ZK connect param that can be deleted, and one for consideration.
        
          
                _includes/tutorials/aggregating-average/kstreams/code/docker-compose.yml
              
                Outdated
          
            Show resolved
            Hide resolved
        
      | 
           There is one more tutorial that refers to something ZooKeeper-related: Background: I wrote that tutorial and borrowed that configuration line from other GitHub examples. Admittedly, this was a copy/paste, and so I don't know its purpose or what the impact would be to remove it. Do we know if that needs to be there?  Would  Or is this a trivial/moot point because ZK can still be removed from Docker Compose (with KIP-500) and this would continue to work?  | 
    
| 
           @ybyzek to your question about log4j filters... given the lack of reply from the connect team and use of those zk filters in other contexts, do we want to keep them for the time being?  | 
    
| 
           @awalther28 agree, let's leave them as-is.  | 
    
| 
           As discussed offline with @awalther28 the failure is unrelated to this PR.  | 
    
GH #562: Remove config dependency on ZooKeeper (not ZooKeeper the service)
Looking into the single test failure but wanted folks input while investigating. Looks like the same test is consistently failing in master as well 🤔 (link to master semaphore tests)
This PR addresses #562. It proposes the following:
SCHEMA_REGISTRY_KAFKASTORE_CONNECTION_URL: 'zookeeper:2181'forSCHEMA_REGISTRY_KAFKASTORE_BOOTSTRAP_SERVERS: 'PLAINTEXT://broker:9092'DESCRIBE EXTENDEDdiff check