Add some basic request metrics #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some basic metrics that work for any rest-utils application. The two commits add metrics at different levels. The first adds some basic TCP connection-level stats by hooking into Jetty, and the second adds HTTP level stats by hooking into Jersey.
It's probably easiest to see what there is by looking at the JMX stats for the example application. A few important questions for review:
request-rate.TopicResource.produceso that all requests could be aggregated intorequest-rate, but that seemed wrong when I also wanted multiple metrics grouped underTopicResource.produce. The current patch just has extra sensors that are always used for the global stats.