Skip to content

Conversation

@vinnybod
Copy link
Member

Description

Brought in some of the changes from bazel-contrib@487c2fa#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

I couldn't just merge master wholesale or cherry-pick because there are other post 6.6.0 changes that we aren't ready to take in yet. Once 6.7.0 is released, we can merge the full upstream here. Tested in [private repo]

Motivation

@vinnybod vinnybod requested a review from a team as a code owner November 21, 2024 22:53
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@vinnybod vinnybod enabled auto-merge (squash) November 21, 2024 23:55
Copy link

@fzakaria fzakaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor review done.
(Let me know if there is a section you want more focus)
Relying on your testing since this has no tests itself and is a custom cherry-pick.

@vinnybod vinnybod merged commit 775d008 into master Nov 22, 2024
1 check passed
@vinnybod vinnybod deleted the vinnybod/DP-15708 branch November 22, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants