Skip to content

Enable wsgi streaming conformance tests with pyvoy #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2025
Merged

Enable wsgi streaming conformance tests with pyvoy #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5b0571
Enable wsgi streaming conformance tests with pyvoy
anuraaga Nov 18, 2025
3709f9a
Tweak gunicorn
anuraaga Nov 18, 2025
356f7a8
Tweak gunicorn
anuraaga Nov 18, 2025
a907549
Tweak gunicorn
anuraaga Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion conformance/test/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,12 @@ async def serve_gunicorn(
cafile: str | None,
port_future: asyncio.Future[int],
):
args = ["--bind=127.0.0.1:0", "--threads=40", "--reuse-port"]
args = [
Copy link
Collaborator Author

@anuraaga anuraaga Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since updating conformance to have connection reuse, gunicorn would have some flakes. A bit disappointed since the vanguard has been so robust otherwise, but doing some research it seems a lot of settings assume nginx in front of gunicorn.

Through some random selection I got these settings to pass CI 3 times, but if anyone happens to know gunicorn better happy to hear any thoughts.

"--bind=127.0.0.1:0",
"--workers=4",
"--worker-class=gevent",
"--reuse-port",
]
if certfile:
args.append(f"--certfile={certfile}")
if keyfile:
Expand Down
6 changes: 1 addition & 5 deletions conformance/test/test_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,7 @@ def test_server_sync(server: str) -> None:
args = maybe_patch_args_with_debug(
[sys.executable, _server_py_path, "--mode", "sync", "--server", server]
)
opts = [
# TODO: Enable full-duplex in pyvoy
"--skip",
"**/bidi-stream/full-duplex/**",
]
opts = []
match server:
case "gunicorn":
# gunicorn doesn't support HTTP/2
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ dev = [
"httpx[http2]==0.28.1",
"hypercorn==0.17.3",
"granian==2.5.7",
"gunicorn==23.0.0",
"gunicorn[gevent]==23.0.0",
"just-bin==1.42.4; sys_platform != 'win32'",
"mkdocs==1.6.1",
"mkdocs-material==9.6.20",
Expand All @@ -53,7 +53,7 @@ dev = [
"pytest-asyncio==1.2.0",
"pytest-cov==7.0.0",
"pytest-timeout==2.4.0",
"pyvoy==0.1.1; sys_platform != 'win32'",
"pyvoy==0.1.2; sys_platform != 'win32'",
Copy link
Collaborator Author

@anuraaga anuraaga Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed an issue that could sporadically hang with WSGI

"ruff~=0.13.2",
"uvicorn==0.37.0",
# Needed to enable HTTP/2 in daphne
Expand Down
Loading