Update references for conformance #158
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebello95
approved these changes
Sep 5, 2023
Collaborator
rebello95
left a comment
rebello95
left a comment
There was a problem hiding this comment.
Looks good, assuming you've grepped the whole codebase for crosstest as well
| - [connect-es][connect-es]: Type-safe APIs with Protobuf and TypeScript | ||
| - [Buf Studio][buf-studio]: Web UI for ad-hoc RPCs | ||
| - [connect-crosstest][connect-crosstest]: Connect, gRPC, and gRPC-Web | ||
| - [conformance][connect-conformance]: Connect, gRPC, and gRPC-Web |
Collaborator
There was a problem hiding this comment.
Suggested change
| - [conformance][connect-conformance]: Connect, gRPC, and gRPC-Web | |
| - [connect-conformance][connect-conformance]: Connect, gRPC, and gRPC-Web |
Member
Author
Collaborator
There was a problem hiding this comment.
I don't have a super strong opinion, good to keep it consistent across repos
This also pins the SwiftProtobuf plugins in `buf.gen.yaml` files so that they don't change from under CI when a new update is released upstream.
Member
Author
|
Closing this because I'm going to split this up into PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames all references and usages to the old crosstest repo so that they begin using the new
connectrpc/conformancerepository in theconnectrpcorganization.Note this is not intended to merge (or build successfully) until the crosstest repo is officially moved.