Use Conformance repo proto files #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 12, 2023 11:20
rebello95
reviewed
Sep 12, 2023
rebello95
reviewed
Sep 12, 2023
Tests/ConnectLibraryTests/ConnectConformance/AsyncAwaitConformance.swift
Outdated
Show resolved
Hide resolved
| try await self.executeTestWithClients { client in | ||
| let expectedErrorDetail = Grpc_Testing_ErrorDetail.with { proto in | ||
| proto.reason = "soirée 🎉" | ||
| proto.domain = "connect-crosstest" |
Member
Author
There was a problem hiding this comment.
It is yeah. This didn't change until the repo was moved. This updates to the commit right before that (follow-up PR will address this).
Tests/ConnectLibraryTests/ConnectConformance/CallbackConformance.swift
Outdated
Show resolved
Hide resolved
| try self.executeTestWithClients { client in | ||
| let expectedErrorDetail = Grpc_Testing_ErrorDetail.with { proto in | ||
| proto.reason = "soirée 🎉" | ||
| proto.domain = "connect-crosstest" |
Tests/ConnectLibraryTests/ConnectConformance/CallbackConformance.swift
Outdated
Show resolved
Hide resolved
…ce.swift Co-authored-by: Michael Rebello <me@michaelrebello.com>
rebello95
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some improvements and updates to the Connect Conformance Tests. Namely:
failServerStreamingchanged here to inspect response parameters and return that amount of responses before failing so that users could test trailers-only responses. This fixes the current test so that it doesn't send any response parameters and expects an error straightaway. In addition, it adds another test to test that some messages are received before the error.Note that this updates Connect-Swift to use commit 6ce5b0, but this is not the current commit. This is because all commits afterwards cause two additional tests to fail (
failUnaryandfailServerStreaming) due to issues with parsing ErrorDetails. Those will be fixed in a follow-up PR.