Skip to content

Rename "target" to "host" and "url" #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2023
Merged

Rename "target" to "host" and "url" #89

merged 2 commits into from
Jan 19, 2023

Conversation

@rebello95
Copy link
Collaborator

@rebello95 rebello95 commented Jan 19, 2023 •
edited
Loading

Removes usage of "target" and replaces it with:

  • "url" in cases where the type is a full RPC URL
  • "host" in cases where the type is a host-only string

@rebello95 rebello95 merged commit 8f70048 into main Jan 19, 2023
@rebello95 rebello95 deleted the replace-target branch January 19, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@buildbreaker buildbreaker buildbreaker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rebello95 @buildbreaker