Replace ClientOption with struct-based config
#92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public let compressionPools: [String: CompressionPool] | ||
| /// Codec to use for serializing/deserializing requests/responses. | ||
| /// Protocol to use for requests and streams. | ||
| public let networkProtocol: NetworkProtocol |
Contributor
There was a problem hiding this comment.
I can make this rename as well
Collaborator
Author
There was a problem hiding this comment.
Cool. I couldn't use protocol since it's a reserved word in swift when lowercased and it'd make ergonomics worse by having to use code tags
buildbreaker
approved these changes
Jan 26, 2023
nakajima
added a commit
to xmtp/xmtp-ios
that referenced
this pull request
Jan 31, 2023
connectrpc/connect-swift#92 changed how client init worked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
ClientOptioninterface and all its conformers with a new struct-based configuration. This has several benefits:ProtocolClientConfig.init)IdentityCompressionPoolThe original approach was taken to more clearly mirror Go, but this new implementation is better for Swift.