✨ Handle kebab-case #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `--dashes` option (subject to change for v1.0) to supports emitting `camelCase` class names in place of `kebab-case` ones. Changes the default to drop invalid (e.g. `kebab-case` names) from the generated TypeScript. Note: Although the generated default has changed, releasing under `0.2` (no breaking change) because the existing emitted TS was invalid. Adds `css` to Prettier config.
Owner
Author
|
FYI @rdparker - I’m thinking of merging this implementation instead of yours. (I’ll merge Monday (2023-12-25) to give you some time to comment any opinions. If you see this after merge, still free to comment. My overall goal is to finalize some of this config over this next week and look to |
Owner
Author
|
@rdparker - Again, feel free to comment or open a separate issue if this does not satisfy your needs!! Thanks in advance. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
--dashesoption (subject to change for v1.0) to supports emittingcamelCaseclass names in place ofkebab-caseones. Changes the default to drop invalid (e.g.kebab-casenames) from the generated TypeScript.Note: Although the generated default has changed, releasing under
0.2(no breaking change) because the existing emitted TS was invalid.Adds
cssto Prettier config.