Skip to content

Initialize visual identity for VS Code extension #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

Initialize visual identity for VS Code extension #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified images/logo.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 12 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "vscode-objectscript",
"displayName": "InterSystems ObjectScript",
"description": "InterSystems ObjectScript language support for Visual Studio Code",
"name": "vscode-consistem-objectscript",
"displayName": "Consistem - InterSystems ObjectScript",
"description": "Consistem - InterSystems ObjectScript language support for Visual Studio Code",
"version": "3.2.1-SNAPSHOT",
"icon": "images/logo.png",
"aiKey": "InstrumentationKey=9cd75d51-697c-406c-a929-2bcf46e97c64;IngestionEndpoint=https://eastus2-4.in.applicationinsights.azure.com/;LiveEndpoint=https://eastus2.livediagnostics.monitor.azure.com/;ApplicationId=a431c56f-8ccc-4b99-b5e9-fce3763215b1",
Expand All @@ -23,7 +23,7 @@
},
"homepage": "https://docs.intersystems.com/components/csp/docbook/DocBook.UI.Page.cls?KEY=GVSCO",
"license": "MIT",
"publisher": "intersystems-community",
"publisher": "consistem-sistemas",
"capabilities": {
Comment on lines 23 to 27
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Update extensionId constant after renaming extension

Renaming the extension in package.json to consistem-sistemas.vscode-consistem-objectscript leaves the runtime constant extensionId in src/extension.ts at the old value intersystems-community.vscode-objectscript. Activation code immediately calls vscode.extensions.getExtension(extensionId) and dereferences its packageJSON; with the new manifest this call now returns undefined, causing a TypeError during activation and the extension never starts. All telemetry and test helpers that rely on the constant are impacted. The constant and any other references must be updated to the new publisher/name pair.

Useful? React with 👍 / 👎.

"untrustedWorkspaces": {
"supported": true
Expand All @@ -45,6 +45,14 @@
{
"name": "John Murray",
"email": "johnm@georgejames.com"
},
{
"name": "Ricardo Junior",
"email": "ricardo.junior@consistem.com.br"
},
{
"name": "Leonardo Anders",
"email": "leonardo.anders@consistem.com.br"
}
],
"engines": {
Expand Down