Removed redundant @method tags & unused imports#498
Merged
greg-1-anderson merged 2 commits intoconsolidation:masterfrom Jan 17, 2017
HypeMC:master
Merged
Removed redundant @method tags & unused imports#498greg-1-anderson merged 2 commits intoconsolidation:masterfrom HypeMC:master
greg-1-anderson merged 2 commits intoconsolidation:masterfrom
HypeMC:master
Conversation
added 2 commits
November 28, 2016 19:48
…ods, moved descriptions to appropriate places. Updated FilesystemStack @method tags to match those in Symfoyn Filesystem.
Member
|
Thanks for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request:
Summary
Removed redundant @method tags & unused imports.
Description
Most @method tags are redundant since, in the meantime, those methods were rewritten to not be magic ones. I've moved all the descriptions to the phpdoc for the actual methods. Also updated the @method tags on the
FilesystemStackclass to match the Symfony filesystem methods.Removed all unused imports & those that tried to import classes that have been removed.