Skip to content

Conversation

@Teagan42
Copy link
Contributor

What

  • add Settings config model
  • allow injecting AsyncQdrantClient into PlexServer and close it on shutdown
  • drive model names and Qdrant options from settings
  • ensure tests and server shutdown close the client

Why

  • enables dependency injection for easier testing
  • avoids leaking Qdrant connections
  • centralizes environment configuration

Affects

  • mcp_plex.server
  • mcp_plex.config
  • tests for server and CLI

Testing

  • uv run ruff check .
  • uv run pytest

Documentation

  • none

https://chatgpt.com/codex/tasks/task_e_68c64efc6df88328ad2ee1c5b8ee15f6

@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
mcp_plex
   cache.py36489%22, 50–52
   loader.py1971095%32–34, 331, 334–338, 663
   server.py2982293%59–60, 102–103, 226, 454, 458, 480–486, 518, 528, 559–560, 577–578, 601, 604–605, 663
TOTAL6513694% 

Tests Skipped Failures Errors Time
29 0 💤 0 ❌ 0 🔥 31.983s ⏱️

@Teagan42 Teagan42 merged commit ed7a76d into main Sep 14, 2025
4 checks passed
@Teagan42 Teagan42 deleted the codex/refactor-plexserver-for-qdrant-integration branch September 14, 2025 05:25
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines +1 to +5
from __future__ import annotations

from pydantic import Field
from pydantic_settings import BaseSettings, SettingsConfigDict

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Declare pydantic-settings dependency

The new configuration module now imports pydantic_settings.BaseSettings to define Settings, but pyproject.toml still omits pydantic-settings from the project dependencies (only the version number was bumped). In a fresh installation the library will raise ModuleNotFoundError as soon as mcp_plex.config is imported. Add pydantic-settings to the dependency list so the package can start successfully.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants