feat: persist IMDb retry queue and fix TMDb season lookup #50
Conversation
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| size = _imdb_retry_queue.qsize() | ||
| for _ in range(size): | ||
| imdb_id = await _imdb_retry_queue.get() | ||
| title = await _fetch_imdb(client, imdb_id) | ||
| if title is None: | ||
| await _imdb_retry_queue.put(imdb_id) |
There was a problem hiding this comment.
[P1] Avoid doubling IMDb retry queue on repeated 429s
When processing the persisted queue, _process_imdb_retry_queue re-enqueues any ID that still returns None, but _fetch_imdb already pushes the same ID back onto _imdb_retry_queue when it hits the final 429 retry (see lines 72‑75). With a rate-limited IMDb API, every failed run doubles the number of queued entries for the same ID, so a single title can balloon to thousands of retries and a large imdb_queue.json, causing unnecessary API calls and potential disk growth once the service recovers. Consider only re-enqueuing here when _fetch_imdb did not already do so.
Useful? React with 👍 / 👎.
What
Why
Affects
Testing
uv run ruff check .uv run pytestDocumentation
https://chatgpt.com/codex/tasks/task_e_68c659dcc1948328a202e8db39d7e781