-
Notifications
You must be signed in to change notification settings - Fork 0
fix(loader): resolve season using parent year #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(loader): resolve season using parent year #52
Conversation
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes season resolution logic by incorporating parent year data from Plex episodes when mapping to TMDb seasons. The fix prioritizes parent year over parent index for year-based season matching and adds proper type checking for fallback scenarios.
- Prioritize parent year over parent index in season resolution logic
- Add fallback to episode year when parent year is unavailable
- Improve type checking for parent index handling in fallback logic
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| mcp_plex/loader.py | Updated season resolution logic to prioritize parent year and improve type checking |
| tests/test_loader_unit.py | Added regression test for parent year fallback scenario |
| pyproject.toml | Version bump to 0.26.18 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary
Testing
uv run ruff check .uv run pytesthttps://chatgpt.com/codex/tasks/task_e_68c66139b7108328b5487081cc3a50da