Skip to content

Conversation

@Teagan42
Copy link
Contributor

Summary

  • incorporate parent year from Plex episodes when mapping to TMDb seasons
  • add regression test for parent year resolution
  • bump version to 0.26.18

Testing

  • uv run ruff check .
  • uv run pytest

https://chatgpt.com/codex/tasks/task_e_68c66139b7108328b5487081cc3a50da

@github-actions
Copy link

github-actions bot commented Sep 14, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
mcp_plex
   cache.py36489%22, 50–52
   imdb_cache.py20290%17–18
   loader.py2972392%33–35, 86, 99–100, 113, 120, 188, 206, 218, 220, 460–462, 472, 475–479, 604, 859
   server.py2982293%59–60, 102–103, 226, 454, 458, 480–486, 518, 528, 559–560, 577–578, 601, 604–605, 663
TOTAL7765193% 

Tests Skipped Failures Errors Time
36 0 💤 0 ❌ 0 🔥 32.453s ⏱️

@Teagan42 Teagan42 requested a review from Copilot September 14, 2025 06:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes season resolution logic by incorporating parent year data from Plex episodes when mapping to TMDb seasons. The fix prioritizes parent year over parent index for year-based season matching and adds proper type checking for fallback scenarios.

  • Prioritize parent year over parent index in season resolution logic
  • Add fallback to episode year when parent year is unavailable
  • Improve type checking for parent index handling in fallback logic

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
mcp_plex/loader.py Updated season resolution logic to prioritize parent year and improve type checking
tests/test_loader_unit.py Added regression test for parent year fallback scenario
pyproject.toml Version bump to 0.26.18

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings September 14, 2025 06:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings September 14, 2025 06:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Teagan42 Teagan42 merged commit de85101 into main Sep 14, 2025
4 checks passed
@Teagan42 Teagan42 deleted the codex/update-year-resolution-logic-for-tmdb-season branch September 30, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants