feat: batch fetch Plex items #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements batch fetching for Plex metadata to reduce repetitive network calls during library loading. Instead of individually fetching each item with fetchItem(), the code now collects all rating keys and retrieves items in bulk using fetchItems().
- Replaces individual
fetchItem()calls with batchfetchItems()operations - Updates test mocks to simulate the new batch fetching behavior
- Documents the batch fetching approach in the AGENTS guidelines
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| mcp_plex/loader.py | Implements batch fetching using fetchItems() for movies, shows, and episodes |
| tests/test_load_from_plex.py | Updates test mocks to support batch fetching and removes individual fetchItem methods |
| AGENTS.md | Documents the batch fetching optimization in architecture notes |
| pyproject.toml | Version bump to 0.26.19 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+319
to
+333
| movie_keys = [int(m.ratingKey) for m in movie_section.all()] | ||
| movies = server.fetchItems(movie_keys) if movie_keys else [] | ||
| movie_tasks = [_augment_movie(client, movie) for movie in movies] | ||
| if movie_tasks: | ||
| results.extend(await _gather_in_batches(movie_tasks, batch_size)) | ||
|
|
||
| show_section = server.library.section("TV Shows") | ||
| for show in show_section.all(): | ||
| full_show = show.fetchItem(show.ratingKey) | ||
| show_keys = [int(s.ratingKey) for s in show_section.all()] | ||
| full_shows = server.fetchItems(show_keys) if show_keys else [] | ||
| for full_show in full_shows: | ||
| show_ids = _extract_external_ids(full_show) | ||
| show_tmdb: Optional[TMDBShow] = None | ||
| if show_ids.tmdb: | ||
| show_tmdb = await _fetch_tmdb_show(client, show_ids.tmdb, tmdb_api_key) | ||
| episode_keys = [int(e.ratingKey) for e in full_show.episodes()] |
There was a problem hiding this comment.
The fetchItems method expects string keys based on the test implementation, but this code converts them to integers. This type mismatch could cause runtime errors when calling the Plex API.
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||
Teagan42
deleted the
codex/update-fetchitems-method-for-batch-retrieval
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
fetchItemsWhy
Affects
loader._load_from_plexTesting
uv run ruff check .uv run pytestDocumentation
AGENTS.mdhttps://chatgpt.com/codex/tasks/task_e_68c665c8cef0832895b1ccc7a9e8fe3b