Skip to content

Conversation

@Teagan42
Copy link
Contributor

What

  • add MediaCache eviction and clear tests
  • add IMDbCache persistence and invalid file tests
  • add Settings env override and invalid value tests
  • check _gather_in_batches failure on zero batch size
  • bump version to 0.26.23

Why

  • increase test coverage and ensure negative paths behave correctly

Affects

  • test suite and project version

Testing

  • uv run ruff check .
  • uv run pytest

Documentation

  • none needed

https://chatgpt.com/codex/tasks/task_e_68c6752c6bf083289af78ee432d3067a

Copilot AI review requested due to automatic review settings September 14, 2025 08:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive negative test cases to improve test coverage for error conditions and edge cases across the caching, configuration, and batch processing modules. The changes also bump the project version to 0.26.23.

  • Add MediaCache eviction behavior and clear functionality tests
  • Add IMDbCache persistence and invalid file handling tests
  • Add Settings environment override and validation error tests
  • Add batch processing failure test for zero batch size

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_imdb_cache.py New test file covering IMDbCache persistence and invalid JSON file handling
tests/test_gather_in_batches.py Added test for zero batch size validation error
tests/test_config.py New test file covering Settings environment override and validation errors
tests/test_cache.py New test file covering MediaCache eviction, clear operations, and missing key handling
pyproject.toml Version bump from 0.26.22 to 0.26.23

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Sep 14, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
mcp_plex
   loader.py3541995%90, 119–128, 139, 141–143, 179, 542–544
   server.py2982293%59–60, 102–103, 226, 454, 458, 480–486, 518, 528, 559–560, 577–578, 601, 604–605, 663
TOTAL8334195% 

Tests Skipped Failures Errors Time
56 0 💤 0 ❌ 0 🔥 35.107s ⏱️

Copilot AI review requested due to automatic review settings September 14, 2025 08:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Teagan42 Teagan42 merged commit 97fe84d into main Sep 14, 2025
4 checks passed
@Teagan42 Teagan42 deleted the codex/add-negative-and-missing-test-cases branch September 14, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants