-
Notifications
You must be signed in to change notification settings - Fork 0
test: add negative cache and settings tests #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive negative test cases to improve test coverage for error conditions and edge cases across the caching, configuration, and batch processing modules. The changes also bump the project version to 0.26.23.
- Add MediaCache eviction behavior and clear functionality tests
- Add IMDbCache persistence and invalid file handling tests
- Add Settings environment override and validation error tests
- Add batch processing failure test for zero batch size
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_imdb_cache.py | New test file covering IMDbCache persistence and invalid JSON file handling |
| tests/test_gather_in_batches.py | Added test for zero batch size validation error |
| tests/test_config.py | New test file covering Settings environment override and validation errors |
| tests/test_cache.py | New test file covering MediaCache eviction, clear operations, and missing key handling |
| pyproject.toml | Version bump from 0.26.22 to 0.26.23 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
What
Why
Affects
Testing
uv run ruff check .uv run pytestDocumentation
https://chatgpt.com/codex/tasks/task_e_68c6752c6bf083289af78ee432d3067a