Skip to content

Conversation

@Teagan42
Copy link
Contributor

@Teagan42 Teagan42 commented Oct 4, 2025

What

  • replace deprecated env usage in Settings with validation_alias to eliminate Pydantic warnings
  • add safeguards in the loader to close stray coroutines, suppress local Qdrant index warnings, and migrate recommendations to query_points
  • ensure the loader CLI test drops the module from sys.modules before executing the script entrypoint to avoid runpy warnings
  • bump the package version and lock file for the release

Why

  • pytest was reporting multiple warnings from configuration, async helpers, Qdrant, and runpy; the changes remove those noisy warnings and prevent future deprecation issues

Affects

  • configuration handling, loader behaviour, server recommendation path, CLI tests, and the recorded project version

Testing

  • uv run pytest

Documentation

  • not needed

https://chatgpt.com/codex/tasks/task_e_68e0f49553548328906ccad63220846e

Copilot AI review requested due to automatic review settings October 4, 2025 10:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR silences pytest warnings by updating deprecated Pydantic configuration patterns and adding warning suppressions for various async and Qdrant-related issues. The changes focus on improving test output quality without affecting functionality.

Key changes:

  • Replace deprecated env parameter with validation_alias in Pydantic settings
  • Add warning suppressions for local Qdrant index operations and module import warnings
  • Update Qdrant recommendation API from deprecated recommend() to query_points()

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
mcp_plex/config.py Replace deprecated env parameter with validation_alias in Pydantic Field definitions
mcp_plex/server.py Migrate from deprecated recommend() to query_points() API for Qdrant recommendations
mcp_plex/loader.py Add warning suppressions for local Qdrant operations and coroutine cleanup safeguards
tests/test_loader_cli.py Add module cleanup to prevent runpy warnings in CLI tests
mcp_plex/init.py Add package-level warning suppression for module import warnings
pyproject.toml Bump version to 0.26.42
docker/pyproject.deps.toml Update version in Docker dependencies file

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
mcp_plex
   loader.py5653294%97, 100–101, 198, 227–231, 233–242, 253, 255–257, 273, 299, 344, 562, 565, 854–856, 952
   server.py4796686%107, 124, 142–143, 278, 299–302, 304–306, 467, 479, 497–504, 524, 526–531, 533–538, 541, 547, 551, 553, 579, 581, 583, 585, 587, 590, 597, 603, 835, 839, 861–867, 899–900, 903, 921, 926, 944, 975–976, 993–994, 1017, 1020–1021, 1068, 1105
TOTAL12349892% 

Tests Skipped Failures Errors Time
69 0 💤 0 ❌ 0 🔥 33.837s ⏱️

@Teagan42 Teagan42 merged commit eaf154c into main Oct 4, 2025
4 checks passed
@Teagan42 Teagan42 deleted the codex/remove-test-warnings branch October 4, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants