Skip to content

Conversation

@Teagan42
Copy link
Contributor

@Teagan42 Teagan42 commented Oct 4, 2025

Summary

  • add rapidfuzz-backed fuzzy matching to Plex player selection and support multiple aliases per identifier
  • normalize player alias configuration to accept string or iterable inputs and update tests accordingly
  • bump project version to 0.26.48 to reflect the new behavior

Testing

  • uv run ruff check .
  • uv run pytest

Documentation

  • n/a

https://chatgpt.com/codex/tasks/task_e_68e1081057d48328817372d22b79c40c

Copilot AI review requested due to automatic review settings October 4, 2025 11:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds fuzzy alias matching functionality for Plex players using rapidfuzz library, allowing for more flexible player identification through approximate string matching and support for multiple aliases per player identifier.

  • Implements fuzzy matching with rapidfuzz for player selection with a 70% similarity threshold
  • Updates player alias configuration to support both string and iterable inputs, normalizing all values to lists
  • Adds comprehensive test coverage for the new fuzzy matching functionality

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
mcp_plex/server.py Implements fuzzy matching logic using rapidfuzz and updates player matching algorithm
mcp_plex/config.py Updates alias configuration to accept string or iterable inputs and normalize to lists
tests/test_server.py Adds tests for fuzzy matching and updates existing tests for new alias format
tests/test_config.py Updates configuration tests to reflect new list-based alias format
pyproject.toml Bumps version to 0.26.48
docker/pyproject.deps.toml Syncs version with main pyproject.toml

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 4, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
mcp_plex
   config.py48785%50, 52–55, 65, 76
   loader.py565699%198, 253, 255–257, 273
   server.py6142995%43–44, 119–120, 148, 252, 256, 277–280, 297, 362, 365, 402, 420–421, 458, 1109, 1131–1137, 1173, 1191, 1196, 1214, 1338, 1375
TOTAL14014297% 

Tests Skipped Failures Errors Time
94 0 💤 0 ❌ 0 🔥 49.379s ⏱️

@Teagan42 Teagan42 merged commit c377a54 into main Oct 4, 2025
4 checks passed
@Teagan42 Teagan42 deleted the codex/update-_match_player-for-fuzzy-alias-matching branch October 4, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants