-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: extract loader channel utilities into shared module #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors loader utilities by extracting batch containers and helper functions from the main loader module into a dedicated shared pipeline module. The refactoring moves utility classes and functions to improve code organization while maintaining backward compatibility.
Key changes:
- Moved batch container classes (
MovieBatch,EpisodeBatch,SampleBatch) and helper utilities topipeline/channels.py - Added backward-compatible underscore aliases in both modules to prevent breaking changes
- Removed duplicate code from the main loader module by importing from the new shared location
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mcp_plex/loader/pipeline/channels.py | New shared module containing batch containers, utility functions, and IMDbRetryQueue class with public exports |
| mcp_plex/loader/init.py | Updated to import utilities from shared module and maintain backward-compatible aliases |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| class MovieBatch: | ||
| """Batch of Plex movie items pending metadata enrichment.""" | ||
|
|
||
| movies: list["PlexPartialObject"] |
Copilot
AI
Oct 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PlexPartialObject type is referenced in quotes but not imported or defined in this module. Consider adding a proper import or type annotation comment to clarify where this type comes from.
| show: "PlexPartialObject" | ||
| episodes: list["PlexPartialObject"] |
Copilot
AI
Oct 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PlexPartialObject type is referenced in quotes but not imported or defined in this module. Consider adding a proper import or type annotation comment to clarify where this type comes from.
Coverage Report
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary
pipeline/channelsmcp_plex.loaderTesting
https://chatgpt.com/codex/tasks/task_e_68e2a0814a44832880cb0add91bfa6de