Fix images output check bug #1999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Feb 12, 2023
AkihiroSuda
reviewed
Feb 12, 2023
djdongjin
force-pushed
the
fix-1997
branch
2 times, most recently
from
87172eb to
5e5e48d
Compare
AkihiroSuda
reviewed
Feb 15, 2023
pkg/testutil/testutil.go
Outdated
| // ImageRepo is a test helper that simply splits a full image name (i.e., not id/digest) | ||
| // by `:` and returns the 1st part. | ||
| func ImageRepo(s string) string { | ||
| return strings.Split(s, ":")[0] |
Member
There was a problem hiding this comment.
Doesn't seem to work when the image name contains a registry port number, e.g., example.com:8080/example
Contributor
There was a problem hiding this comment.
I think we can use imgutil.ParseRepoTag and return the first part.
Signed-off-by: Jin Dong <jindon@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1997
Signed-off-by: Jin Dong jindon@amazon.com