Build containerd and runc for specific arch with xx #2007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @AkihiroSuda is something like this acceptable. |
AkihiroSuda
reviewed
Feb 14, 2023
AkihiroSuda
reviewed
Feb 14, 2023
manugupt1
force-pushed
the
build-arch
branch
5 times, most recently
from
710d0db to
eeab95e
Compare
manugupt1
changed the title
manugupt1
force-pushed
the
build-arch
branch
from
eeab95e to
ad5c0b0
Compare
AkihiroSuda
reviewed
Feb 16, 2023
AkihiroSuda
reviewed
Feb 16, 2023
manugupt1
force-pushed
the
build-arch
branch
from
ad5c0b0 to
82165e2
Compare
AkihiroSuda
reviewed
Feb 16, 2023
| cp -a bypass4netns bypass4netnsd /out/arm64 | ||
| RUN xx-go --wrap | ||
| RUN GO=xx-go GOARCH=${TARGETARCH} CC=$(xx-info)-gcc make static && \ | ||
| xx-verify --static bypass4netns && cp -a bypass4netns bypass4netnsd /out/${TARGETARCH} |
Member
There was a problem hiding this comment.
When GO=xx-go is set, no need to run --wrap and specify GOARCH, CC, etc.
Contributor
Author
There was a problem hiding this comment.
thanks! sorry! misunderstood earlier. Thanks for helping with this PR throughout
manugupt1
force-pushed
the
build-arch
branch
from
82165e2 to
1482953
Compare
manugupt1
commented
Feb 16, 2023
Dockerfile
Outdated
| cp -a bypass4netns bypass4netnsd /out/amd64 | ||
| RUN GOARCH=arm64 CC=aarch64-linux-gnu-gcc make static && \ | ||
| cp -a bypass4netns bypass4netnsd /out/arm64 | ||
| RUN xx-go --wrap |
Signed-off-by: Manu Gupta <manugupt1@gmail.com>
manugupt1
force-pushed
the
build-arch
branch
from
1482953 to
fa9f627
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.